Sasserisop
/
MATH201
1
0
Fork 1
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

master #1

Open
DashCampbell wants to merge 4 commits from DashCampbell/MATH201:master into master
pull from: DashCampbell/MATH201:master
merge into: Sasserisop:master
Conversation 0 Commits 4 Files Changed 9 +755 -399
DashCampbell commented 2023-12-30 11:11:54 -07:00
First-time contributor
Copy Link

WIP
Hello, its Dash, your website is very nice. My editor auto-formatted some of the files, so there's a lot less changes to the code then what Github says. That being said, here's a list of the changes I made.

  • The links to the lecture notes on the homepage are now generated automatically, the links are appended after the third br tag in _index.md
  • The links to the lecture notes in the search menu are sorted by lecture number, and buggy links are filtered out.
  • The search menu now overlaps the main page.
  • The image icon in the tool bar now toggle displays a input range slider that resizes the images in the lecture notes.
  • Minor UI changes.

I encountered some errors with how links are handled in javascript. This is likely because sasserisop.com is the root url on your website, but on localhost /MATH201 is the root url. If your getting errors because of wrong links, I suggest editing these lines inside themes/zettels/assets/js/search.js

Line 185: a_tag.href = val[1]; //permalink
Line 213: const permalink = note.permalink
Line 281: const requestURL = root + '/index.json';

WIP Hello, its Dash, your website is very nice. My editor auto-formatted some of the files, so there's a lot less changes to the code then what Github says. That being said, here's a list of the changes I made. - The links to the lecture notes on the homepage are now generated automatically, the links are appended after the third br tag in _index.md - The links to the lecture notes in the search menu are sorted by lecture number, and buggy links are filtered out. - The search menu now overlaps the main page. - The image icon in the tool bar now toggle displays a input range slider that resizes the images in the lecture notes. - Minor UI changes. I encountered some errors with how links are handled in javascript. This is likely because sasserisop.com is the root url on your website, but on localhost /MATH201 is the root url. If your getting errors because of wrong links, I suggest editing these lines inside themes/zettels/assets/js/search.js `Line 185: a_tag.href = val[1]; //permalink` `Line 213: const permalink = note.permalink` `Line 281: const requestURL = root + '/index.json';`
DashCampbell added 4 commits 2023-12-30 11:11:55 -07:00
This pull request has changes conflicting with the target branch.
  • content/_index.md
  • themes/zettels/layouts/index.html
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b DashCampbell-master master
git pull master

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff DashCampbell-master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Sasserisop/MATH201#1
No description provided.
Delete Branch "DashCampbell/MATH201:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?